Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rafthttp: add v3.x to supported streams #6449

Merged
merged 1 commit into from
Sep 16, 2016
Merged

rafthttp: add v3.x to supported streams #6449

merged 1 commit into from
Sep 16, 2016

Conversation

gyuho
Copy link
Contributor

@gyuho gyuho commented Sep 16, 2016 •
edited
Loading

Fix TestReleaseUpgrade*.

It was hanging in https://github.com/coreos/etcd/blob/master/rafthttp/stream.go#L445-L446.

We now found this because we have had 3.0.0 in master branch, which is always less than 3.0.x of recent releases.

@gyuho
Copy link
Contributor Author

gyuho commented Sep 16, 2016

@heyitsanthony @xiang90 Please review. All tests are passing now. Thanks.

@gyuho gyuho mentioned this pull request Sep 16, 2016
Merged
@xiang90
Copy link
Contributor

xiang90 commented Sep 16, 2016

LGTM. We also should add 3.0 one into 3.0 release branch.

@gyuho
Copy link
Contributor Author

gyuho commented Sep 16, 2016

@xiang90 Sure, will add it to release-3.0 manually.

@gyuho gyuho merged commit 5c20531 into etcd-io:master Sep 16, 2016
@gyuho gyuho deleted the supported-stream branch September 16, 2016 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gyuho @xiang90